Remove brute-force workaround for DurableObject name lookup#257
Merged
Conversation
The Durable Object runtime now passes through the name used with `idFromName`, so it is available inside the DO constructor via `state.id().name()` (cloudflare/workerd#2240). Previously `get_durable_object_name` brute-forced the name by enumerating every configured log (and batcher shard) and comparing `id_from_name` results against the DO's id. Replace it with the runtime-provided name: - Sequencers and cleaners are unsharded, so their DO name is the base log name; they read `state.id().name()` directly. - Batchers are always addressed with a shard suffix (`{name}_{shard_id:x}`), so a new `get_sharded_durable_object_base_name` helper strips the trailing `_{shard_id:x}` component to recover the base log name.
bwesterb
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Durable Object runtime now passes through the name used with
idFromName, so it is available inside the DO constructor viastate.id().name()(cloudflare/workerd#2240).Previously
get_durable_object_namebrute-forced the name by enumerating every configured log (and batcher shard) and comparingid_from_nameresults against the DO's id. Replace it with the runtime-provided name:state.id().name()directly.{name}_{shard_id:x}), so a newget_sharded_durable_object_base_namehelper strips the trailing_{shard_id:x}component to recover the base log name.Closes #201